Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21405#discussion_r190228283
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeBlockSuite.scala
---
@@ -120,11 +120,11 @@ class CodeBlockSuite extends SparkFunSuite {
|}""".stripMargin
val aliasedParam = JavaCode.variable("aliased", expr.javaType)
- val aliasedInputs = code.asInstanceOf[CodeBlock].blockInputs.map {
- case _: SimpleExprValue => aliasedParam
- case other => other
+
+ // We want to replace all occurrences of `expr` with the variable
`aliasedParam`.
+ val aliasedCode = code.transformExprValues {
+ case SimpleExprValue("1 + 1", _) => aliasedParam
--- End diff --
nit: I know the current code works correctly. How about replacing `_` with
`CodeGenerator.javaClass(IntegerType)`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
