Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21221#discussion_r190353891
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -209,6 +210,16 @@ class DAGScheduler(
       private[scheduler] val eventProcessLoop = new 
DAGSchedulerEventProcessLoop(this)
       taskScheduler.setDAGScheduler(this)
     
    +  /** driver heartbeat for collecting metrics */
    +  private val heartbeater: Heartbeater = new Heartbeater(reportHeartBeat, 
"driver-heartbeater",
    --- End diff --
    
    lets not put this in the DAGScheduler please -- this class is fragile 
enough as it is :)
    
    I think this should just go in SparkContext.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to