Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21379#discussion_r190382338
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
 ---
    @@ -78,7 +79,12 @@ private[sql] object JDBCRelation extends Logging {
         // Overflow and silliness can happen if you subtract then divide.
         // Here we get a little roundoff, but that's (hopefully) OK.
         val stride: Long = upperBound / numPartitions - lowerBound / 
numPartitions
    -    val column = partitioning.column
    +    val column = if (jdbcOptions.quotePartitionColumnName) {
    +      val dialect = JdbcDialects.get(jdbcOptions.url)
    +      dialect.quoteIdentifier(partitioning.column)
    --- End diff --
    
    Yeah


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to