Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3003#discussion_r19637064
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/TaskResultGetter.scala ---
    @@ -64,11 +75,15 @@ private[spark] class TaskResultGetter(sparkEnv: 
SparkEnv, scheduler: TaskSchedul
                   val deserializedResult = 
serializer.get().deserialize[DirectTaskResult[_]](
                     serializedTaskResult.get)
                   sparkEnv.blockManager.master.removeBlock(blockId)
    -              deserializedResult
    +              (deserializedResult, size)
               }
    -          result.metrics.resultSize = serializedData.limit()
    +
    +          result.metrics.resultSize = size
               scheduler.handleSuccessfulTask(taskSetManager, tid, result)
             } catch {
    +          case e: BigResultException =>
    +            taskSetManager.abort("Total size of result is bigger than 
maxResultSize, " +
    --- End diff --
    
    The abort() message is a little different than the logInfos, because that's 
the one that gets propagated directly back to the user (it eventually becomes 
the error message in the Spark exception that the user gets)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to