Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3017#discussion_r19638167
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -985,15 +985,19 @@ private[hive] object HiveQl {
In(nodeToExpr(value), list.map(nodeToExpr))
case Token("TOK_FUNCTION",
Token(BETWEEN(), Nil) ::
- Token("KW_FALSE", Nil) ::
+ kw ::
target ::
minValue ::
maxValue :: Nil) =>
val targetExpression = nodeToExpr(target)
- And(
- GreaterThanOrEqual(targetExpression, nodeToExpr(minValue)),
+ val betweenExpr =
+ And(GreaterThanOrEqual(targetExpression, nodeToExpr(minValue)),
LessThanOrEqual(targetExpression, nodeToExpr(maxValue)))
--- End diff --
This is a Nit, but if you have to break the line I think it should be
formatted as:
```scala
And(
GreaterThanOrEqual(targetExpression, nodeToExpr(minValue)),
LessThanOrEqual(targetExpression, nodeToExpr(maxValue)))
```
This way the tree structure is more clear.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
