Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/21428#discussion_r191020258
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/shuffle/UnsafeRowWriter.scala
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming.continuous.shuffle
+
+import org.apache.spark.Partitioner
+import org.apache.spark.rpc.RpcEndpointRef
+import org.apache.spark.sql.catalyst.expressions.UnsafeRow
+
+/**
+ * A [[ContinuousShuffleWriter]] sending data to [[UnsafeRowReceiver]]
instances.
--- End diff --
Another thought, not something that needs to be done now. But it might be
overall cleaner if the ContinuousShuffleWriter and Reader are coupled together
in a joint interface. This is because each writer implementation is always tied
to a specific reader implementation, so they are always coupled together.
Consider something like this.
```
trait ContinuousShuffleManager {
def createWriter(writerId: Int, numReaders: Int): ContinuousShuffleWriter
def createReader(readerId: Int, numWriters: Int): ContinuousShuffleReader
}
```
I am just guessing that the params on the createX interfaces, I might be
missing something. But I feel that a small set of params should be sufficient
for any implementation figure out everything else. Also, other
management/control layer stuff will go into the manager implementation. Like,
for example, if the writers and readers need to exchange initial setup
information (e.g. RPC endpoint details) through the driver, then the
implementation of that would go into the manager.
Think about it as your building out rest of the architecture.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
