Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21434#discussion_r191090821
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -207,7 +208,7 @@ NULL
     #' tmp <- mutate(df, v1 = create_array(df$mpg, df$cyl, df$hp))
     #' head(select(tmp, array_contains(tmp$v1, 21), size(tmp$v1)))
     #' head(select(tmp, array_max(tmp$v1), array_min(tmp$v1)))
    -#' head(select(tmp, array_position(tmp$v1, 21), array_sort(tmp$v1)))
    +#' head(select(tmp, array_position(tmp$v1, 21), array_repeat(21, 5L), 
array_sort(tmp$v1)))
    --- End diff --
    
    also for `5L`, `5` should be ok and more clear as well


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to