Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19691#discussion_r191206009
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
 ---
    @@ -293,6 +313,15 @@ class AstBuilder(conf: SQLConf) extends 
SqlBaseBaseVisitor[AnyRef] with Logging
         }
       }
     
    +  /**
    +   * Create a partition specification map without optional values
    +   * and a partition filter specification.
    +   */
    +  protected def visitPartition(
    --- End diff --
    
    can we avoid this method? I find it quite confusing (I mean it is a bit 
weird to return a tuple with a Map and a Seq of different things....) We can 
add a new parameter to `AlterTableDropPartitionCommand` and use the other two 
method directly...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to