Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191584812
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,20 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging with Seria
*/
private[spark] def getenv(name: String): String = System.getenv(name)
+ /**
+ * Wrapper method for get*() methods which require some specific value
format. This catches
+ * any [[NumberFormatException]] or [[IllegalArgumentException]] and
re-raises it with the
+ * incorrectly configured key in the exception message.
+ */
+ private def catchIllegalArgument[T](key: String)(getValue: => T): T = {
--- End diff --
According to what it actually does `catchIllegalArgument` don't seems to be
a great name for this function, maybe `catchIllegalValue`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
