Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21370#discussion_r191591455
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
    @@ -291,37 +289,57 @@ class Dataset[T] private[sql](
             }
           }
     
    +      rows = rows.map {
    +        _.zipWithIndex.map { case (cell, i) =>
    +          if (truncate > 0) {
    +            StringUtils.leftPad(cell, colWidths(i))
    +          } else {
    +            StringUtils.rightPad(cell, colWidths(i))
    +          }
    +        }
    +      }
    --- End diff --
    
    We should do this in `showString`? And we can move `minimumColWidth` into 
the `showString` in that case?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to