Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191653358
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
<version>1.10.19</version>
<scope>test</scope>
</dependency>
+ <dependency>
--- End diff --
right - not saying we should completely reinvent the wheel of course. Does
including this in the root pom bring the rxjava jar into the spark-core's
dependency chain? If so, we should avoid it.
license - you are right, for Apache 2.0 we don't need to list. but `jmock`
yes the way you have.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
