Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2475#discussion_r19646942
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/types/dataTypes.scala 
---
    @@ -389,7 +389,7 @@ case class ArrayType(elementType: DataType, 
containsNull: Boolean) extends DataT
      * @param dataType The data type of this field.
      * @param nullable Indicates if values of this field can be `null` values.
      */
    -case class StructField(name: String, dataType: DataType, nullable: 
Boolean) {
    +case class StructField(name: String, dataType: DataType, nullable: Boolean 
= true) {
    --- End diff --
    
    do we need the default value for nullable? seems to me you are setting 
nullable explicitly everywhere


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to