Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21428#discussion_r191747894
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/shuffle/RPCContinuousShuffleReader.scala
 ---
    @@ -48,7 +46,7 @@ private[shuffle] case class ReceiverEpochMarker(writerId: 
Int) extends UnsafeRow
      * TODO: Support multiple source tasks. We need to output a single epoch 
marker once all
      * source tasks have sent one.
      */
    -private[shuffle] class UnsafeRowReceiver(
    +private[shuffle] class RPCContinuousShuffleReader(
    --- End diff --
    
    nit: If we need the rename here, how about other messages name and 
comments? 
    
https://github.com/apache/spark/pull/21428/files#diff-4072457048f805637bfce2c779608756R29
    
https://github.com/apache/spark/pull/21428/files#diff-4072457048f805637bfce2c779608756R35



---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to