Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21439
Thank you @maropu for your review of the PR.
> better to add tests in json-functions.sql?
What kind of tests would you expect in `json-functions.sql`. Probably you
would expect tests that are different from added to
`JsonExpressionsSuite.scala`.
> Can we also accept primitive arrays in to_json?
I believe it should be implemented in another PR because the changes
required for `to_json` don't intersect with this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
