Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21450#discussion_r191851612
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkSubmitCommandBuilder.java
---
@@ -229,7 +238,7 @@
args.add(join(",", pyFiles));
}
- if (isExample) {
+ if (isExample && requiresMainClass) {
--- End diff --
In what situation will `requiresAppResource` be different from
`requiresMainClass` at this point?
It seems to me they're basically the same. The only point in your code
where they differ is in the no-arg constructor, which is not used by the
`run-example` script.
Seems to me like you could rename the existing variable to
`isSpecialCommand` or something and use it instead for both cases.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
