Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191938203
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -141,26 +141,14 @@ public void fetchChunk(
StreamChunkId streamChunkId = new StreamChunkId(streamId, chunkIndex);
handler.addFetchRequest(streamChunkId, callback);
- channel.writeAndFlush(new
ChunkFetchRequest(streamChunkId)).addListener(future -> {
--- End diff --
Are the changes to these `.addListener()` calls primarily cleanup /
refactoring? Is the intent to reduce the amount of _new_ duplicate code which
would otherwise be added to `uploadStream` in this file?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
