Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21470#discussion_r192192426
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2675,15 +2675,6 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
         withSQLConf(SQLConf.CASE_SENSITIVE.key -> "false") {
           sql("SELECT struct(1 a) UNION ALL (SELECT struct(2 A))")
           sql("SELECT struct(1 a) EXCEPT (SELECT struct(2 A))")
    -
    -      withTable("t", "S") {
    -        sql("CREATE TABLE t(c struct<f:int>) USING parquet")
    -        sql("CREATE TABLE S(C struct<F:int>) USING parquet")
    -        Seq(("c", "C"), ("C", "c"), ("c.f", "C.F"), ("C.F", 
"c.f")).foreach {
    -          case (left, right) =>
    -            checkAnswer(sql(s"SELECT * FROM t, S WHERE t.$left = 
S.$right"), Seq.empty)
    --- End diff --
    
    this test case wants to test set operation, but here it's testing filter. 
the new tests should've covered it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to