Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19602#discussion_r192286502
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/HiveClientSuite.scala
---
@@ -66,6 +65,19 @@ class HiveClientSuite(version: String)
client
}
+ private def attr(name: String): Attribute = {
+ name match {
+ case "ds" =>
+ AttributeReference("ds", IntegerType)()
--- End diff --
This is error-prone, we should look up the attribute by name from
`spark.table("test")`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
