Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2998#discussion_r19653172
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -92,6 +92,29 @@ trait CaseConversionExpression {
}
}
+
+trait StringCalculationExpression {
--- End diff --
This trait seems only used by `Length`, how about just merge them? I think
we can extract the trait in the future if we have more string operators returns
`IntegerType`. Sorry not sure if you're planning on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
