Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21482#discussion_r192574664
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -907,6 +907,30 @@ setMethod("initcap",
                 column(jc)
               })
     
    +#' @details
    +#' \code{isinf}: Returns true if the column is Infinity.
    +#' @rdname column_nonaggregate_functions
    +#' @aliases isnan isnan,Column-method
    +#' @note isinf since 2.4.0
    +setMethod("isinf",
    --- End diff --
    
    For `isNaN` case, `functions.R` only defines `isnan`. `isNaN` is defined in 
`column.R`. If we really want to have both `isInf` and `isinf` like `isNaN` and 
`isnan`, maybe to follow it instead having two duplicate method definition here 
is better.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to