Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21486#discussion_r192976073
  
    --- Diff: core/src/test/scala/org/apache/spark/HeartbeatReceiverSuite.scala 
---
    @@ -207,6 +210,54 @@ class HeartbeatReceiverSuite
         assert(fakeClusterManager.getExecutorIdsToKill === Set(executorId1, 
executorId2))
       }
     
    +  test("expired executor should not be offered again (SPARK-24387)") {
    +    scheduler = spy(new TaskSchedulerImpl(sc))
    --- End diff --
    
    Just little question want to make sure, here use spy because we need to 
call `runningTasksByExecutors ` later?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to