Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2685#discussion_r19654494
  
    --- Diff: dev/run-tests ---
    @@ -142,17 +142,24 @@ CURRENT_BLOCK=$BLOCK_BUILD
       # We always build with Hive because the PySpark Spark SQL tests need it.
       BUILD_MVN_PROFILE_ARGS="$SBT_MAVEN_PROFILES_ARGS -Phive -Phive-0.12.0"
     
    -  echo "[info] Building Spark with these arguments: 
$BUILD_MVN_PROFILE_ARGS"
     
       # NOTE: echo "q" is needed because sbt on encountering a build file with 
failure
       #+ (either resolution or compilation) prompts the user for input either 
q, r, etc
       #+ to quit or retry. This echo is there to make it not block.
    -  # NOTE: Do not quote $BUILD_MVN_PROFILE_ARGS or else it will be 
interpreted as a 
    +  # NOTE: Do not quote $BUILD_MVN_PROFILE_ARGS or else it will be 
interpreted as a
       #+ single argument!
       # QUESTION: Why doesn't 'yes "q"' work?
       # QUESTION: Why doesn't 'grep -v -e "^\[info\] Resolving"' work?
    +  # First build with 0.12 to ensure patches do not break the hive 12 build
    +  echo "[info] Compile with hive 0.12"
       echo -e "q\n" \
    -    | sbt/sbt $BUILD_MVN_PROFILE_ARGS clean package assembly/assembly \
    +    | sbt/sbt $BUILD_MVN_PROFILE_ARGS clean hive/compile 
hive-thriftserver/compile \
    --- End diff --
    
    It should be, `BUILD_MVN_PROFILE_ARGS` is defined above with 
`-Phive-0.12.0`:
    
    ```
      BUILD_MVN_PROFILE_ARGS="$SBT_MAVEN_PROFILES_ARGS -Phive -Phive-0.12.0"
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to