Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r194109752
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala
---
@@ -87,11 +89,37 @@ class KubernetesConfSuite extends SparkFunSuite {
APP_ID,
None,
MAIN_CLASS,
- APP_ARGS)
+ APP_ARGS,
+ None)
assert(kubernetesConfWithoutMainJar.sparkConf.get("spark.jars").split(",")
=== Array("local:///opt/spark/jar1.jar"))
+
assert(kubernetesConfWithoutMainJar.sparkConf.get(MEMORY_OVERHEAD_FACTOR) ===
0.1)
}
+ test("Creating driver conf with a python primary file") {
--- End diff --
Just a follow up we should have a test for with Python and overriding
MEMORY_OVERHEAD_FACTOR (e.g. test to make sure that setIfMissing since we had
it the other way earlier in the PR).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
