Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21520
@kiszk @mgaido91 Thanks for your comment!
> What do you think about starting doing the needed changes in smaller PRs
which focus only on specific part and forbidding the string interpolation after
those have made the needed changes smaller?
By disallowing string interpolation in code blocks, any strings passed into
a code block won't pass the compilation. It is also more guaranteed that we
don't miss any strings. It is why this change is quite big and not in many
smaller pieces. Most important is, I need to have all the changes together to
see if we can pass all the tests once we completely forbid string interpolation.
But it doesn't mean we need to review and merge this big change. It is
still possible to break this into smaller PRs. It may work like this:
1. Split a part of change into a smaller PR, review it and finally merge it.
2. Incorporate the merged change back to this PR. Make test passed. Go back
to step 1.
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
