Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21505#discussion_r194294961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -125,7 +125,6 @@ object DateTimeUtils {
.getOrElseUpdate(timeZone, {
Calendar.getInstance(timeZone)
})
- c.clear()
--- End diff --
Seems `setTimeInMillis` can result in all fields set. If so, `clear` is
redundant.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
