GitHub user caneGuy opened a pull request:

    https://github.com/apache/spark/pull/21526

    [SPARK-24515][CORE] No need to warning when output commit coordination 
enabled

    ## What changes were proposed in this pull request?
    
    No need to warning user when output commit coordination enabled
    ```
    // When speculation is on and output committer class name contains 
"Direct", we should warn
    // users that they may loss data if they are using a direct output 
committer.
    val speculationEnabled = self.conf.getBoolean("spark.speculation", false)
    val outputCommitterClass = hadoopConf.get("mapred.output.committer.class", 
"")
    if (speculationEnabled && outputCommitterClass.contains("Direct")) {
     val warningMessage =
     s"$outputCommitterClass may be an output committer that writes data 
directly to " +
     "the final location. Because speculation is enabled, this output committer 
may " +
     "cause data loss (see the case in SPARK-10063). If possible, please use an 
output " +
     "committer that does not have this behavior (e.g. FileOutputCommitter)."
     logWarning(warningMessage)
    }
    ```
    
    ## How was this patch tested?
    UT


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/caneGuy/spark zhoukang/fix-warning

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21526.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21526
    
----
commit 6bac1531929e914764d980e4eb4228a10436876b
Author: zhoukang <zhoukang199191@...>
Date:   2018-06-11T08:57:11Z

    [SPARK][CORE] No need to warning when output commit coordination enabled

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to