Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21258#discussion_r194514611
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ComplexTypeSuite.scala
 ---
    @@ -186,6 +186,50 @@ class ComplexTypeSuite extends SparkFunSuite with 
ExpressionEvalHelper {
         }
       }
     
    +  test("MapFromArrays") {
    +    def createMap(keys: Seq[Any], values: Seq[Any]): Map[Any, Any] = {
    +      // catalyst map is order-sensitive, so we create ListMap here to 
preserve the elements order.
    +      scala.collection.immutable.ListMap(keys.zip(values): _*)
    +    }
    +
    +    val intSeq = Seq(5, 10, 15, 20, 25)
    +    val longSeq = intSeq.map(_.toLong)
    +    val strSeq = intSeq.map(_.toString)
    +    val integerSeq = Seq[java.lang.Integer](5, 10, 15, 20, 25)
    +    val intWithNullSeq = Seq[java.lang.Integer](5, 10, null, 20, 25)
    +    val longWithNullSeq = intSeq.map(java.lang.Long.valueOf(_))
    +
    +    val intArray = Literal.create(intSeq, ArrayType(IntegerType, false))
    +    val longArray = Literal.create(longSeq, ArrayType(LongType, false))
    +    val strArray = Literal.create(strSeq, ArrayType(StringType, false))
    +
    +    val integerArray = Literal.create(integerSeq, ArrayType(IntegerType, 
true))
    +    val intwithNullArray = Literal.create(intWithNullSeq, 
ArrayType(IntegerType, true))
    +    val longwithNullArray = Literal.create(longWithNullSeq, 
ArrayType(LongType, true))
    --- End diff --
    
    `longWithNullArray`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to