Github user jkbradley commented on the pull request:

    https://github.com/apache/spark/pull/2607#issuecomment-61326184
  
    @manishamde  LGTM!  Thanks for updating the Strategy.  I think this is 
ready to be merged, though I still plan to update the train* methods to 
eliminate the ones taking lots of parameters.  In particular, I plan to:
    * Make builder methods for Strategy and Boosting Strategy to make them easy 
to construct from Java.
    * Eliminate the train* methods taking lots of parameters.
    * Write examples in Scala and Java to make sure everything is easy to do 
from Java.
    Does that sound OK?
    
    Thanks very much for contributing GBT!  It's a big step forward for MLlib.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to