Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21501#discussion_r194626092
  
    --- Diff: python/pyspark/ml/feature.py ---
    @@ -2582,25 +2582,31 @@ class StopWordsRemover(JavaTransformer, 
HasInputCol, HasOutputCol, JavaMLReadabl
                           typeConverter=TypeConverters.toListString)
         caseSensitive = Param(Params._dummy(), "caseSensitive", "whether to do 
a case sensitive " +
                               "comparison over the stop words", 
typeConverter=TypeConverters.toBoolean)
    +    locale = Param(Params._dummy(), "locale", "locale of the input. 
ignored when case sensitive " +
    +                   "is true", typeConverter=TypeConverters.toString)
    --- End diff --
    
    And also don't forget to mention default value is JVM default locale.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to