Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21516#discussion_r194679672
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
 ---
    @@ -122,8 +122,9 @@ private[spark] class MesosClusterScheduler(
         conf: SparkConf)
       extends Scheduler with MesosSchedulerUtils {
       var frameworkUrl: String = _
    +  private val metricsSource = new MesosClusterSchedulerSource(this)
    --- End diff --
    
    Shouldn't this be configurable? Is it ok to start the dispatcher by default 
with a metric system set up?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to