Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21068#discussion_r195469104
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocatorBlacklistTracker.scala
---
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.yarn
+
+import scala.collection.JavaConverters._
+import scala.collection.mutable
+import scala.collection.mutable.HashMap
+
+import org.apache.hadoop.yarn.client.api.AMRMClient
+import org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest
+
+import org.apache.spark.SparkConf
+import org.apache.spark.deploy.yarn.config._
+import org.apache.spark.internal.Logging
+import org.apache.spark.internal.config._
+import org.apache.spark.util.{Clock, SystemClock, Utils}
+
+/**
+ * YarnAllocatorBlacklistTracker is responsible for tracking the
blacklisted nodes
+ * and synchronizing the node list to YARN.
+ *
+ * Blacklisted nodes are coming from two different sources:
+ *
+ * <ul>
+ * <li> from the scheduler as task level blacklisted nodes
+ * <li> from this class (tracked here) as YARN resource allocation
problems
+ * </ul>
+ *
+ * The reason to realize this logic here (and not in the driver) is to
avoid possible delays
+ * between synchronizing the blacklisted nodes with YARN and resource
allocations.
+ */
+private[spark] class YarnAllocatorBlacklistTracker(
+ sparkConf: SparkConf,
+ amClient: AMRMClient[ContainerRequest],
+ failureTracker: FailureTracker)
+ extends Logging {
+
+ private val defaultTimeout = "1h"
+
+ private val blacklistTimeoutMillis =
+
sparkConf.get(BLACKLIST_TIMEOUT_CONF).getOrElse(Utils.timeStringAsMs(defaultTimeout))
+
+ private val launchBlacklistEnabled =
sparkConf.get(YARN_EXECUTOR_LAUNCH_BLACKLIST_ENABLED)
+
+ private val maxFailuresPerHost = sparkConf.get(MAX_FAILED_EXEC_PER_NODE)
+
+ private val allocatorBlacklist = new HashMap[String, Long]()
+
+ private var currentBlacklistedYarnNodes = Set.empty[String]
+
+ private var schedulerBlacklist = Set.empty[String]
+
+ private var numClusterNodes = Int.MaxValue
+
+ def setNumClusterNodes(numClusterNodes: Int): Unit = {
+ this.numClusterNodes = numClusterNodes
+ }
+
+ def handleResourceAllocationFailure(hostOpt: Option[String]): Unit = {
+ hostOpt match {
+ case Some(hostname) if launchBlacklistEnabled =>
+ // failures on an already blacklisted nodes are not even tracked.
+ // otherwise, such failures could shutdown the application
+ // as resource requests are asynchronous
+ // and a late failure response could exceed MAX_EXECUTOR_FAILURES
+ if (!schedulerBlacklist.contains(hostname) &&
+ !allocatorBlacklist.contains(hostname)) {
+ failureTracker.registerFailureOnHost(hostname)
+ updateAllocationBlacklistedNodes(hostname)
+ }
+ case _ =>
+ failureTracker.registerExecutorFailure()
+ }
+ }
+
+ private def updateAllocationBlacklistedNodes(hostname: String): Unit = {
+ val failuresOnHost = failureTracker.numFailuresOnHost(hostname)
+ if (failuresOnHost > maxFailuresPerHost) {
+ logInfo(s"blacklisting $hostname as YARN allocation failed
$failuresOnHost times")
+ allocatorBlacklist.put(
+ hostname,
+ failureTracker.clock.getTimeMillis() + blacklistTimeoutMillis)
+ refreshBlacklistedNodes()
+ }
+ }
+
+ def setSchedulerBlacklistedNodes(schedulerBlacklistedNodesWithExpiry:
Set[String]): Unit = {
+ this.schedulerBlacklist = schedulerBlacklistedNodesWithExpiry
+ refreshBlacklistedNodes()
+ }
+
+ def isAllNodeBlacklisted: Boolean = currentBlacklistedYarnNodes.size >=
numClusterNodes
+
+ private def refreshBlacklistedNodes(): Unit = {
+ removeExpiredYarnBlacklistedNodes()
+ val allBlacklistedNodes = schedulerBlacklist ++
allocatorBlacklist.keySet
+ synchronizeBlacklistedNodeWithYarn(allBlacklistedNodes)
+ }
+
+ private def synchronizeBlacklistedNodeWithYarn(nodesToBlacklist:
Set[String]): Unit = {
+ // Update blacklist information to YARN ResourceManager for this
application,
+ // in order to avoid allocating new Containers on the problematic
nodes.
+ val additions = (nodesToBlacklist --
currentBlacklistedYarnNodes).toList.sorted
+ val removals = (currentBlacklistedYarnNodes --
nodesToBlacklist).toList.sorted
+ if (additions.nonEmpty) {
+ logInfo(s"adding nodes to YARN application master's blacklist:
$additions")
+ }
+ if (removals.nonEmpty) {
+ logInfo(s"removing nodes from YARN application master's blacklist:
$removals")
+ }
+ amClient.updateBlacklist(additions.asJava, removals.asJava)
+ currentBlacklistedYarnNodes = nodesToBlacklist
+ }
+
+ private def removeExpiredYarnBlacklistedNodes(): Unit = {
+ val now = failureTracker.clock.getTimeMillis()
+ allocatorBlacklist.retain { (_, expiryTime) => expiryTime > now }
+ }
+}
+
+/**
+ * FailureTracker is responsible for tracking executor failures both for
each host separately
+ * and for all hosts altogether.
+ */
+private[spark] class FailureTracker(
+ sparkConf: SparkConf,
+ val clock: Clock = new SystemClock) extends Logging {
+
+ private val executorFailuresValidityInterval =
+
sparkConf.get(config.EXECUTOR_ATTEMPT_FAILURE_VALIDITY_INTERVAL_MS).getOrElse(-1L)
+
+ // Queue to store the timestamp of failed executors for each host
+ private val failedExecutorsTimeStampsPerHost = mutable.Map[String,
mutable.Queue[Long]]()
+
+ private val failedExecutorsTimeStamps = new mutable.Queue[Long]()
+
+ private def updateAndCountFailures(failedExecutorsWithTimeStamps:
mutable.Queue[Long]): Int = {
+ val endTime = clock.getTimeMillis()
+ while (executorFailuresValidityInterval > 0 &&
+ failedExecutorsWithTimeStamps.nonEmpty &&
+ failedExecutorsWithTimeStamps.head < endTime -
executorFailuresValidityInterval) {
--- End diff --
double indent the condition
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
