Github user erikerlandson commented on a diff in the pull request:
https://github.com/apache/spark/pull/21572#discussion_r195866275
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -37,11 +37,17 @@ if [ -z "$uidentry" ] ; then
fi
SPARK_K8S_CMD="$1"
-if [ -z "$SPARK_K8S_CMD" ]; then
- echo "No command to execute has been provided." 1>&2
- exit 1
-fi
-shift 1
+case "$SPARK_K8S_CMD" in
+ driver | driver-py | executor)
+ shift 1
+ ;;
+ "")
+ ;;
+ *)
+ echo "No SPARK_K8S_CMD provided: proceeding in pass-through mode..."
--- End diff --
Overall this looks good to me. Looking at this simplified logic, the
logging message should probably be more like:
"Non-spark-k8s command provided, proceeding in pass-through mode..."
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
