Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21542#discussion_r195884323
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/image/HadoopUtils.scala 
---
    @@ -42,9 +42,11 @@ private object RecursiveFlag {
         val old = Option(hadoopConf.get(flagName))
         hadoopConf.set(flagName, value.toString)
         try f finally {
    -      old match {
    -        case Some(v) => hadoopConf.set(flagName, v)
    -        case None => hadoopConf.unset(flagName)
    +      // avoid false positive of DLS_DEAD_LOCAL_STORE_IN_RETURN by SpotBugs
    --- End diff --
    
    It is not a real problem. However, I cannot find to disable only this check 
in `findPuzzles`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to