Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21568#discussion_r195920498
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -104,11 +105,34 @@ class SQLQueryTestSuite extends QueryTest with
SharedSQLContext {
// We should ignore this file from processing.
)
+ private val configsAllJoinTypes =
Seq(Seq(SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key ->
--- End diff --
Oh, I meant that here you definitely want to test against different join
types, maybe it is good if you can describe which join type each config set
means.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
