Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21550#discussion_r196242923
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala ---
@@ -354,8 +354,8 @@ class JsonFunctionsSuite extends QueryTest with
SharedSQLContext {
test("SPARK-24027: from_json - map<string, map<string, int>>") {
val in = Seq("""{"a": {"b": 1}}""").toDS()
- val schema = MapType(StringType, MapType(StringType, IntegerType))
- val out = in.select(from_json($"value", schema))
+ val schema = "map<string, map<string, int>>"
--- End diff --
A general suggestion. Create a new test case for these changes, instead of
modifying the existing ones.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
