GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/3048
SPARK-1209 [CORE] (Take 2) SparkHadoop{MapRed,MapReduce}Util should not use
package org.apache.hadoop
@andrewor14 Another try at SPARK-1209, to address
https://github.com/apache/spark/pull/2814#issuecomment-61197619
I successfully tested with `mvn -Dhadoop.version=1.0.4 -DskipTests clean
package; mvn -Dhadoop.version=1.0.4 test` I assume that is what failed Jenkins
last time. I also tried `-Dhadoop.version1.2.1` and `-Phadoop-2.4 -Pyarn
-Phive` for more coverage.
So this is why the class was put in `org.apache.hadoop` to begin with, I
assume. One option is to leave this as-is for now and move it only when Hadoop
1.0.x support goes away.
This is the other option, which adds a call to force the constructor to be
public at run-time. It's probably less surprising than putting Spark code in
`org.apache.hadoop`, but, does involve reflection. A `SecurityManager` might
forbid this, but it would forbid a lot of stuff Spark does. This would also
only affect Hadoop 1.0.x it seems.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-1209
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3048.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3048
----
commit eb618208651bd7e9bb27292bc1d662f849a5725b
Author: Sean Owen <[email protected]>
Date: 2014-10-13T19:48:42Z
Move SparkHadoopMapRedUtil / SparkHadoopMapReduceUtil from
org.apache.hadoop to org.apache.spark
commit 466e179a67dd6f3e62abea2a8d8df23e35eb7e2b
Author: Sean Owen <[email protected]>
Date: 2014-10-16T14:02:31Z
Disable MIMA warnings resulting from moving the class -- this was also part
of the PairRDDFunctions type hierarchy though?
commit 0d48f4bbe1564dae9d9115813250811396858fb5
Author: Sean Owen <[email protected]>
Date: 2014-11-01T09:37:55Z
For Hadoop 1.0.x, make certain constructors public, which were public in
later versions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
