Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2971#discussion_r19707896
--- Diff: core/src/main/scala/org/apache/spark/scheduler/ResultTask.scala
---
@@ -89,13 +89,13 @@ private[spark] object ResultTask {
* input RDD's partitions).
*/
private[spark] class ResultTask[T, U](
- stageId: Int,
+ _stageId: Int,
--- End diff --
Take a look at here: https://gist.github.com/rxin/6be132f46b72c27d8f89
I think if the parent constructor declares the field as val or var, then it
is fine. Otherwise it is not. So technically in this case it should be fine to
not rename, but it is better to rename it explicitly just to avoid the compiler
behavior change (since this might be a corner case) in the future.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
