Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3053#discussion_r19708335
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -1178,6 +1178,10 @@ private[spark] class BlockManager(
def stop(): Unit = {
blockTransferService.close()
+ if (shuffleClient ne blockTransferService) {
+ // Closing should be idempotent, but maybe not for the
NioBlockTransferService.
+ shuffleClient.close()
--- End diff --
This and the other leaks would only leak during the
ExternalShuffleIntegrationSuite, which only creates a handful of SparkContexts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
