Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21598#discussion_r196751433
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -556,21 +559,28 @@ class DataFrameFunctionsSuite extends QueryTest with
SharedSQLContext {
checkAnswer(df8.selectExpr("arrays_zip(v1, v2)"), expectedValue8)
}
- test("map size function") {
+ def testSizeOfMap(sizeOfNull: Any): Unit = {
val df = Seq(
(Map[Int, Int](1 -> 1, 2 -> 2), "x"),
(Map[Int, Int](), "y"),
(Map[Int, Int](1 -> 1, 2 -> 2, 3 -> 3), "z"),
(null, "empty")
).toDF("a", "b")
- checkAnswer(
- df.select(size($"a")),
- Seq(Row(2), Row(0), Row(3), Row(-1))
- )
- checkAnswer(
- df.selectExpr("size(a)"),
- Seq(Row(2), Row(0), Row(3), Row(-1))
- )
+
+ checkAnswer(df.select(size($"a")), Seq(Row(2), Row(0), Row(3),
Row(sizeOfNull)))
+ checkAnswer(df.selectExpr("size(a)"), Seq(Row(2), Row(0), Row(3),
Row(sizeOfNull)))
+ }
+
+ test("map size function - legacy") {
+ withSQLConf("spark.sql.legacy.sizeOfNull" -> "true") {
--- End diff --
`SQLConf. LEGACY_SIZE_OF_NULL.key -> "true"`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
