Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21495#discussion_r196993585
--- Diff:
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoopInterpreter.scala
---
@@ -21,8 +21,22 @@ import scala.collection.mutable
import scala.tools.nsc.Settings
import scala.tools.nsc.interpreter._
-class SparkILoopInterpreter(settings: Settings, out: JPrintWriter) extends
IMain(settings, out) {
- self =>
+class SparkILoopInterpreter(settings: Settings, out: JPrintWriter,
initializeSpark: () => Unit)
+ extends IMain(settings, out) { self =>
--- End diff --
We can fix them in place. There are many other style nits too. It's not
worth swiping them making the backport harder.
I am fine with ignoring such nits and they don't block this PR but it's not
something we should say the opposite side is okay.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
