Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21603#discussion_r197381611
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -31,7 +31,7 @@ import org.apache.spark.sql.types._
/**
* Some utility function to convert Spark data source filters to Parquet
filters.
*/
-private[parquet] class ParquetFilters(pushDownDate: Boolean) {
+private[parquet] class ParquetFilters(pushDownDate: Boolean,
inFilterThreshold: Int) {
--- End diff --
nit: not a big deal, but since now SQLConf are available also on executor
side, can we get its value inside the class rather than outside? If we add more
configurations this constructor might explode...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
