Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21626#discussion_r197662496
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/InferSchema.scala
 ---
    @@ -0,0 +1,162 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions.aggregate
    +
    +import scala.util.Try
    +
    +import com.fasterxml.jackson.core.JsonFactory
    +
    +import org.apache.spark.sql.catalyst.InternalRow
    +import org.apache.spark.sql.catalyst.expressions.{AttributeReference, 
Expression, ExpressionDescription, JsonExprUtils}
    +import org.apache.spark.sql.catalyst.json.{CreateJacksonParser, 
JsonInferSchema, JSONOptions}
    +import 
org.apache.spark.sql.catalyst.json.JsonInferSchema.compatibleRootType
    +import org.apache.spark.sql.catalyst.util.DropMalformedMode
    +import org.apache.spark.sql.types.{DataType, StringType, StructType}
    +import org.apache.spark.unsafe.types.UTF8String
    +
    +@ExpressionDescription(
    +  usage = """_FUNC_(expr,[options]) - Infers schema for JSON `expr` by 
using JSON `options`.""")
    +case class InferSchema(
    --- End diff --
    
    We probably shouldn't just call it `InferSchema` in case we add a similar 
function, for example, for CSV.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to