Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21620#discussion_r197737278
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -536,6 +536,13 @@ object TypeCoercion {
               case None => c
             }
     
    +      case aj @ ArrayJoin(arr, d, nr) if 
!ArrayType(StringType).acceptsType(arr.dataType) &&
    +        ArrayType.acceptsType(arr.dataType) =>
    +        val containsNull = 
arr.dataType.asInstanceOf[ArrayType].containsNull
    +        ImplicitTypeCasts.implicitCast(arr, ArrayType(StringType, 
containsNull))
    --- End diff --
    
    nit: usually we try to avoid long chains of functions, what about:
    ```
    ImplicitTypeCasts.implicitCast(arr, ArrayType(StringType, containsNull)) 
match {
      ...
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to