Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20345#discussion_r198029399
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
 ---
    @@ -141,14 +141,16 @@ object ExtractEquiJoinKeys extends Logging with 
PredicateHelper {
     }
     
     /**
    - * A pattern that collects the filter and inner joins.
    + * A pattern that collects the filter and inner joins and skip projections 
with attributes only.
      *
      *          Filter
      *            |
      *        inner Join
      *          /    \            ---->      (Seq(plan0, plan1, plan2), 
conditions)
      *      Filter   plan2
      *        |
    + *      Project
    --- End diff --
    
    I don't think this case would be covered, i.e., Project-over-Filter or 
Filter-over-Project.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to