Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/21596#discussion_r198112472
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
---
@@ -25,8 +25,13 @@ import org.apache.spark.util.{Benchmark, Utils}
/**
* The benchmarks aims to measure performance of JSON parsing when
encoding is set and isn't.
- * To run this:
- * spark-submit --class <this class> --jars <spark sql test jar>
+ * To run:
+ * mvn clean package -pl sql/core -DskipTests
+ * ./dev/make-distribution.sh --name local-dist
+ * cd dist/
+ * ./bin/spark-submit --class
org.apache.spark.sql.execution.datasources.json.JSONBenchmarks \
+ * ../sql/core/target/spark-sql_2.11-2.4.0-SNAPSHOT-tests.jar >
/tmp/output.txt
--- End diff --
Oops, forgot to add:
```
MacBook-Pro-van-Fokko:spark fokkodriesprong$ git diff
diff --git
a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
index 3b273f81d7..0598406d33 100644
---
a/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
+++
b/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonBenchmarks.scala
@@ -29,8 +29,9 @@ import org.apache.spark.util.{Benchmark, Utils}
* mvn clean package -pl sql/core -DskipTests
* ./dev/make-distribution.sh --name local-dist
* cd dist/
- * ./bin/spark-submit --class
org.apache.spark.sql.execution.datasources.json.JSONBenchmarks \
- * ../sql/core/target/spark-sql_2.11-2.4.0-SNAPSHOT-tests.jar >
/tmp/output.txt
+ * ./bin/spark-submit bin/spark-submit \
+ * --class
org.apache.spark.sql.execution.datasources.json.JSONBenchmarks \
+ * --jars ./sql/core/target/spark-sql_*-tests.jar
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
