[GitHub] spark pull request #21644: [SPARK-24660][SHS] Show correct error pages when ...

Tue, 26 Jun 2018 07:16:00 -0700 

GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/21644

    [SPARK-24660][SHS] Show correct error pages when downloading logs

    ## What changes were proposed in this pull request?
    
    SHS is showing bad errors when trying to download logs is not successful. 
This may happen because the requested application doesn't exist or the user 
doesn't have permissions for it, for instance.
    
    The PR fixes the response when errors occur, so that they are displayed 
properly.
    
    ## How was this patch tested?
    
    manual tests
    
    **Before the patch:**
     1. Unauthorized user
    ![screen shot 2018-06-26 at 3 53 33 
pm](https://user-images.githubusercontent.com/8821783/41918118-f8b37e70-795b-11e8-91e8-d0250239f09d.png)
    
     2. Non-existing application
    ![screen shot 2018-06-26 at 3 25 19 
pm](https://user-images.githubusercontent.com/8821783/41918082-e3034c72-795b-11e8-970e-cee4a1eae77f.png)
    
    **After the patch** 
     1. Unauthorized user
    ![screen shot 2018-06-26 at 3 41 29 
pm](https://user-images.githubusercontent.com/8821783/41918155-0d950476-795c-11e8-8d26-7b7ce73e6fe1.png)
    
     2. Non-existing application
    ![screen shot 2018-06-26 at 3 40 37 
pm](https://user-images.githubusercontent.com/8821783/41918175-1a14bb88-795c-11e8-91ab-eadf29190a02.png)
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-24660

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21644
    
----
commit 8b26a5359e9d759668d6608ebf13952d4fa088c7
Author: Marco Gaido <marcogaido91@...>
Date:   2018-06-26T14:01:28Z

    [SPARK-24660][SHS] Show correct error pages when downloading logs

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to