Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21644#discussion_r198586841
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/OneApplicationResource.scala
---
@@ -140,11 +140,9 @@ private[v1] class AbstractApplicationResource extends
BaseAppResource {
.header("Content-Type", MediaType.APPLICATION_OCTET_STREAM)
.build()
} catch {
- case NonFatal(e) =>
- Response.serverError()
- .entity(s"Event logs are not available for app: $appId.")
- .status(Response.Status.SERVICE_UNAVAILABLE)
- .build()
+ case NonFatal(_) =>
+ UIUtils.buildErrorResponse(Response.Status.SERVICE_UNAVAILABLE,
--- End diff --
But isn't the type being set in the exception now? Seems like the same
thing that happens in other cases, where the response is set to json but the
exception overrides it when thrown.
But if it doesn't really work, then ok.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
