Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21221#discussion_r198618559
--- Diff:
core/src/main/scala/org/apache/spark/status/AppStatusListener.scala ---
@@ -669,6 +686,29 @@ private[spark] class AppStatusListener(
}
}
}
+ event.executorUpdates.foreach { updates: Array[Long] =>
+ // check if there is a new peak value for any of the executor level
memory metrics
+ liveExecutors.get(event.execId).foreach { exec: LiveExecutor =>
+ if (exec.peakExecutorMetrics.compareAndUpdate(updates)) {
+ maybeUpdate(exec, now)
+ }
+ }
+ }
+ }
+
+ override def onStageExecutorMetrics(executorMetrics:
SparkListenerStageExecutorMetrics): Unit = {
+ val now = System.nanoTime()
+
+ // check if there is a new peak value for any of the executor level
memory metrics
--- End diff --
do you need this here *and* in `onExecutorMetricsUpdate`? I guess you do,
because one is for reading from the logs, and the other is for the live UI? If
so its worth putting in a comment about that.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
