Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21451#discussion_r198657121
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -1341,12 +1390,16 @@ private[spark] class BlockManager(
           try {
             val onePeerStartTime = System.nanoTime
             logTrace(s"Trying to replicate $blockId of ${data.size} bytes to 
$peer")
    +        // This thread keeps a lock on the block, so we do not want the 
netty thread to unlock
    +        // block when it finishes sending the message.
    +        val mb = new BlockManagerManagedBuffer(blockInfoManager, blockId, 
data, false,
    --- End diff --
    
    s/mb/buffer
    
    Confusing in a place that deals with sizes all over.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to