Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21511#discussion_r198659423
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
 ---
    @@ -104,6 +104,20 @@ private[spark] object Config extends Logging {
           .stringConf
           .createOptional
     
    +  val KUBERNETES_EXECUTOR_LIMIT_GPUS =
    --- End diff --
    
    If this needs to be shared it should go in a separate feature step that is 
applied in both the driver builder and the executor builder. There's probably a 
better way to share the resource requests / limits code here, probably by 
extracting the shared parts into a separate step that is parameterized by 
different values from the Spark configuration.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to